Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search compressed files #43011

Closed
roblourens opened this issue Feb 6, 2018 · 5 comments
Closed

Search compressed files #43011

roblourens opened this issue Feb 6, 2018 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues

Comments

@roblourens
Copy link
Member

roblourens commented Feb 6, 2018

Issue Type: Feature Request

Description

Ripgrep now supports searching compressed files, for some formats.

Currently gz, bz2, xz, and lzma files are supported.

See BurntSushi/ripgrep@f007f94

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (3f8cf53, 2018-02-03T01:26:08.181Z)
OS version: Darwin x64 17.3.0

@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Feb 6, 2018
@roblourens roblourens self-assigned this Feb 6, 2018
@vscodebot vscodebot bot added the insiders label Feb 6, 2018
@BurntSushi
Copy link

@roblourens Note that ripgrep currently only looks for gzip, bzip2 and xz binaries. So if those aren't available, then this won't work. It was said that 7z.exe could be used on Windows. It'd be fairly easy to add that in, but I've never used 7z before. Does that sound right?

@roblourens
Copy link
Member Author

That does sound right but what about .zip files? There are usually tools included with the OS to decompress those files. I probably wouldn't enable it in vscode unless it works for typical .zips.

@BurntSushi
Copy link

@roblourens We punted on archive formats because that is quite a bit more involved feature! ripgrep doesn't handle .tar.gz either.

@roblourens
Copy link
Member Author

Oh, got it. I suspect that an option to search compressed files in vscode would confuse people if it didn't search archive formats, but I'll have to think about it.

@vscodebot vscodebot bot removed the insiders label Feb 7, 2018
@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Sep 12, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 12, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants