Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[obsolete] [email protected] #40102

Closed
alexdima opened this issue Dec 12, 2017 · 2 comments · May be fixed by maxemiliang/vscode-ext#31 or stefanonepa/vscode-chrome-debug#5
Closed

[obsolete] [email protected] #40102

alexdima opened this issue Dec 12, 2017 · 2 comments · May be fixed by maxemiliang/vscode-ext#31 or stefanonepa/vscode-chrome-debug#5
Assignees
@roblourens
Labels
debt Code quality issues
Milestone
January 2018

Comments

@alexdima
Copy link
Member

alexdima commented Dec 12, 2017 •
edited
Loading

This comes in all the way from here

[trace] [obsolete] Backtrace for [email protected]:
		/Users/alex/src/vscode/extensions/ms-vscode.node-debug2/package-lock.json
[trace] Backtrace for [email protected]:
		/Users/alex/src/vscode/yarn.lock

The idea of this issue is that we stop shipping N times the same module at different versions and that we keep up-to-date with our dependencies.
@alexdima alexdima added the debt Code quality issues label Dec 12, 2017
@alexdima alexdima added this to the December 2017/January 2018 milestone Dec 12, 2017
@roblourens
Copy link
Member

I should update it, but node-debug dependencies are not shared with vscode so we'll still ship two copies.

@alexdima
Copy link
Member Author

Sure, we will continue to ship two copies. But being up-to-date is good by itself. Plus I believe it zips a bit better ;)

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
debt Code quality issues
Projects
None yet
Milestone
January 2018
2 participants
@roblourens @alexdima