Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet abbreviation: Text, doesn't expand text containing unclosed quotes (well) #38807

Closed
ericnjuki opened this issue Nov 20, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@ericnjuki
Copy link

  • VSCode Version: 1.18.1
  • OS Version: Windows 10 Home

Steps to Reproduce:

  1. Use emmet text abbreviation with any html tag in a html file. Text within braces must have odd number of apostrophes/quotes:
    p{this doesn't work, for me}

  2. Attempt to expand abbreviation:
          2.1. Try uh, deriving context menu? (Ctrl+Space)
          2.2. Running Emmet: Expand Abbreviation
          2.3. Adding "emmet.triggerExpansionOnTab": true and hitting tab

  3. Use with concatenation (odd number of quotes in at least one of the braces):
    p{this doesn't work, for me}+div{'this' doesn't work too}
    and repeat step 2

Reproduces without extensions: Yes

Expected results
for steps
2: <p>this doesn't work, for me</p>
3: <p>this doesn't work, for me</p><div>'this' doesn't work too</div>

Actual results
for steps:
2.1: Expand abbreviation doesn't appear
2.2: Error Failed to expand abbreviation
2.3: Error Failed to expand abbreviation
(errors...)

3: <p>this doesn't work, for me}+div{'this' doesn't work too</p>
(weird expansions)

@vscodebot vscodebot bot added the emmet Emmet related issues label Nov 20, 2017
@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug and removed new release labels Nov 21, 2017
@ramya-rao-a ramya-rao-a added this to the November 2017 milestone Nov 21, 2017
@ramya-rao-a ramya-rao-a modified the milestones: November 2017, December 2017 Dec 4, 2017
@ramya-rao-a
Copy link
Contributor

The upstream issue emmetio/abbreviation#8 was fixed
The changes have been absorbed to the emmet extension via 41e7dbc

@gushuro gushuro added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants