Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display total number of found entries after a search #36933

Closed
sergiofigueras opened this issue Oct 25, 2017 · 2 comments
Closed

Display total number of found entries after a search #36933

sergiofigueras opened this issue Oct 25, 2017 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations

Comments

@sergiofigueras
Copy link

Hello guys,

I've a suggestion and I would like to share with you and get your thoughts on that as well. As vscode is such a versatile code editor, sometimes we also use it as a text editor, since its quite simple, just press Cmd + N and you've a new beauty tab.

But unfortunately, there's one condition on it that I did not seen in Atom, Sublime, or even simple text editors / log stream readers. Its about displaying the total amount of found entries in a search. And as I couldn't find an option to configure it, I'm assuming that its the default behavior of vscode.

It would be nice if users could see the number of found entries on search, but unfortunately it seems that vscode just stops the counting after 999, always displaying a static string "X of 999+ items", instead of this, why not display like "X of 1766 items"? For example, today, I had to do this twice because I was checking some log files, and I had to open Atom just do to this. And its not the first time for this week. So, maybe other folks also have the same need.

  • VSCode Version: 1.16.1
  • OS Version: OSX 10.12.6

Steps to Reproduce:

  1. Create a file with 1000 entries of some string, like " TEST ".
  2. Press cmd + f and try to search for " TEST "
  3. We can see that a search box is displayed, and it says "X of 999+ items".

screen shot 2017-10-25 at 4 10 01 pm

What do you guys thinks about that proposal?

Thanks! :)

@vscodebot vscodebot bot added the workbench label Oct 25, 2017
@isidorn isidorn assigned rebornix and unassigned isidorn Oct 26, 2017
@isidorn isidorn added editor-find Editor find operations and removed workbench labels Oct 26, 2017
@isidorn
Copy link
Contributor

isidorn commented Oct 26, 2017

fyi @alexandrudima

@alexdima
Copy link
Member

Duplicate of #496

On the insiders channel this limit has been bumped to 20k.

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations
Projects
None yet
Development

No branches or pull requests

4 participants