Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM: repository status could get some alignment #35039

Closed
bpasero opened this issue Sep 26, 2017 · 6 comments
Closed

SCM: repository status could get some alignment #35039

bpasero opened this issue Sep 26, 2017 · 6 comments
Assignees
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@bpasero
Copy link
Member

bpasero commented Sep 26, 2017

Testing: #35034

I think visually it would be nice if the repository status would be aligned at least on the left hand side. We always seem to have the branch icon followed by the branch name and I think the branch icon should always show aligned across all repositories:

image

@bpasero
Copy link
Member Author

bpasero commented Sep 26, 2017

Actually this is more complicated and needs more thinking:

image

It seems to me we have some structure per row:

  • the repository name
  • the repository provider name
  • the number of changes
  • the branch
  • dirty indicators (*, +)
  • the sync action
  • incoming / outgoing changes

Some way of aligning these would be nice, otherwise the view becomes very noisy.

@joaomoreno
Copy link
Member

This is also nothing we can really control, given that providers can contribute whatever they want. We might want to drop the status items though, and just allow to have inline, square, actions.

@joaomoreno joaomoreno added the under-discussion Issue is under discussion for relevance, priority, approach label Sep 27, 2017
@bpasero
Copy link
Member Author

bpasero commented Sep 27, 2017

We might want to drop the status items though

What does that mean?

@joaomoreno
Copy link
Member

Those status items were never meant to be shown there, but in the status bar. I just repurpose them to that location. But maybe it's best if we call it a whole different location and have semantic actions in that location.

@bpasero
Copy link
Member Author

bpasero commented Sep 27, 2017

Don't get me wrong, I like all the info I am seeing there. But visually I wonder if we can align things better that belong together.

@joaomoreno
Copy link
Member

Closing this for now.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants