Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegExp Replace stopped if 998+ matches found #34517

Closed
SilverBut opened this issue Sep 16, 2017 · 4 comments
Closed

RegExp Replace stopped if 998+ matches found #34517

SilverBut opened this issue Sep 16, 2017 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations

Comments

@SilverBut
Copy link

SilverBut commented Sep 16, 2017

  • Version 1.16.1
  • OS Version: Linux 4.12.13-1-ARCH Open Source VS Code #1 SMP PREEMPT Fri Sep 15 06:36:43 UTC 2017 x86_64 GNU/Linux
  • Commit 27492b6
  • Date 2017-09-14T16:26:20.018Z
  • Shell 1.7.3
  • Renderer 58.0.3029.110
  • Node 7.9.0
  • Architecture x64

Steps to Reproduce:

  1. Build this test document in a new window(just kept ctrl+c and ctrl+v)
a b c 10
<Repeat last line for 999 times>
  1. Ctrl+H to call Replacement, and input this as your regexp to replace from, and replace it to 123123:
^(\S+)\s+?(.+)\s+?(\d+)\d*$
  1. Replace for all

Excepted Result:

All lines should be replaced to 123123

Produced Result:

Nothing happened.

Futher Steps:

  1. Change the first line to dddddd

  2. Replace use those arguments again

Produced Result:

All lines except the first line is replace to 123123

Reproduces without extensions: Yes

@vscodebot vscodebot bot added editor editor-find Editor find operations labels Sep 16, 2017
@SilverBut
Copy link
Author

Seems related with #32522, #33573, #33989 and #11973.

One of them is submitted in 29 days ago? Really? For a bug in a common function?

@alexdima
Copy link
Member

Duplicate of #32522 i.e. 54ca510 also fixes this.

@alexdima alexdima added *duplicate Issue identified as a duplicate of another issue(s) and removed editor-1000-limit labels Sep 28, 2017
@alexdima alexdima added this to the September 2017 milestone Sep 28, 2017
@SilverBut
Copy link
Author

@alexandrudima Seems not fixed, at least at this version. Have not released yet?

Version 1.16.1
Commit 27492b6
Date 2017-09-14T16:26:20.018Z
Shell 1.7.3
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

@alexdima
Copy link
Member

alexdima commented Oct 9, 2017

@SilverBut The fix should come with 1.17 .

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations
Projects
None yet
Development

No branches or pull requests

3 participants