Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all results count in the find widget (even if not highlighted) #31673

Closed
shanalikhan opened this issue Jul 28, 2017 · 6 comments
Closed

Show all results count in the find widget (even if not highlighted) #31673

shanalikhan opened this issue Jul 28, 2017 · 6 comments
Labels
editor-find Editor find operations feature-request Request for new features or functionality

Comments

@shanalikhan
Copy link

Hi,
Currently it shows the 999 occurrences and highlights them.
But i need to get all the occurrences like in Notepad++ count in Find Dialog.

Selection should tell the count of all the occurrences and can highlight of first 999 and can highlight more when scrolled down.
But All Occurrences Count is very important.

image
@vscodebot vscodebot bot added editor editor-find Editor find operations labels Jul 28, 2017
@rebornix rebornix added the feature-request Request for new features or functionality label Jul 28, 2017
@hamxabaig
Copy link

hamxabaig commented Jul 30, 2017 •
edited
Loading

Its this file , right ?
Do we need to change the current behaviour or we can add a config for this ? Let me know happy to provide PR for this one.

@brezanac
Copy link

brezanac commented Aug 4, 2017 •
edited
Loading

This is a biggie for me. I often use search to count occurrences in files and not being able to do it for larger files completely defeats the purpose of using VSCode at all.

@hamxabaig
Copy link

@rebornix May you check my comment if thats correct. I can work on this one then

@ToMakeSense
Copy link

ToMakeSense commented Aug 10, 2017 •
edited
Loading

totally agree on you!!! #11973 #19208

Find Widget UI enhanced design should also take this into consideration #2220

@ToMakeSense ToMakeSense mentioned this issue Sep 2, 2017
Closed
@alexdima alexdima self-assigned this Sep 28, 2017
@alexdima alexdima added the debt Code quality issues label Sep 28, 2017
@alexdima alexdima removed the editor label Nov 24, 2017
@alexdima alexdima changed the title Show all occurances Count when selected Show all results count in the find widget (even if not highlighted) Dec 12, 2017
@alexdima alexdima removed the debt Code quality issues label Dec 12, 2017
@alexdima alexdima removed their assignment Apr 18, 2018
@shanalikhan
Copy link
Author

is there any update on this one

@rebornix rebornix removed their assignment Sep 5, 2018
@alexdima
Copy link
Member

alexdima commented Sep 6, 2018

The only update is that the visual decorations are now drawn on the first 20.000 results. All operations in the find widget work correctly for the entire set, it is just the visual highlights that are painted only for the first 20.000.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
editor-find Editor find operations feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@brezanac @rebornix @alexdima @ToMakeSense @shanalikhan @hamxabaig