Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

200 MB file opens but crashes after several edits #31543

Closed
michelkaporin opened this issue Jul 27, 2017 · 4 comments
Closed

200 MB file opens but crashes after several edits #31543

michelkaporin opened this issue Jul 27, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-textbuffer Editor text buffer freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues info-needed Issue requires more information from poster

Comments

@michelkaporin
Copy link
Contributor

michelkaporin commented Jul 27, 2017

Testing #30243

OS: Windows 32bit
Extensions: none
Hardware configuration: 8 GB RAM (7.82 usable), x64

  1. Generate 200MB non-random content file using Dummy File Creator (46 lines of spaces)
  2. Open it
  3. Do single edit
    Observe crash.

Seems like 300MB limit for 32bit is very rough and is probably very hardware specific. Maybe we should have more variables to define limit size?

This is how memory looks when editor opened untouched:
image

Opening and editing for 100MB works fine (although with lags obviously).

Dummy File Creator: http://www.mynikko.com/dummy/

@vscodebot vscodebot bot added the workbench label Jul 27, 2017
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues labels Nov 27, 2017
@rebornix rebornix self-assigned this Jan 29, 2018
@rebornix rebornix added editor-textbuffer Editor text buffer and removed editor editor-textbuffer Editor text buffer labels Jan 29, 2018
@rebornix
Copy link
Member

@michelkaporin do you still have the machine you put in the description? We changed the buffer implementation and this issue is mitigated but I don't have similar machine to test.

@rebornix rebornix added the info-needed Issue requires more information from poster label Feb 13, 2018
@michelkaporin
Copy link
Contributor Author

michelkaporin commented Feb 14, 2018

@rebornix unfortunately not, but perhaps @dbaeumer can try to validate on his Windows machine.

@rebornix
Copy link
Member

Shares the same root cause (the string length limit) as #51625 and can be mitigated when we adopt Electron 3.

@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 12, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 12, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-textbuffer Editor text buffer freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants