Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeDataProvider: expanded nodes under a collapsed node don't work #30918

Closed
weinand opened this issue Jul 18, 2017 · 25 comments
Closed

TreeDataProvider: expanded nodes under a collapsed node don't work #30918

weinand opened this issue Jul 18, 2017 · 25 comments
Assignees
@joaomoreno @sandy081 @alexr00
Labels
api bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues tree-widget Tree widget issues verified Verification succeeded
Milestone
July 2019

Comments

@weinand
Copy link
Contributor

weinand commented Jul 18, 2017 •
edited
Loading

from the getChildren method of a TreeDataProvider return an "expanded" root with "collapsed" children. Under those "collapsed" children return "expanded" nodes with children.

In the displayed tree view open a "collapsed" node.
Observe: the children under that collapsed node are shown expanded, but they have no children. If you collapse and then reopen them, the children appear.

2017-07-18_11-50-35
@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 18, 2017
@weinand weinand assigned sandy081 and unassigned weinand Jul 18, 2017
@weinand weinand added bug Issue identified by VS Code Team member as probable bug api and removed debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 18, 2017
@sandy081 sandy081 added this to the July 2017 milestone Jul 18, 2017
@sandy081 sandy081 added the tree-views Extension tree view issues label Jul 18, 2017
@sandy081 sandy081 marked this as a duplicate of #29381 Jul 27, 2017
@sandy081 sandy081 mentioned this issue Jul 27, 2017
Closed
@sandy081 sandy081 modified the milestones: August 2017, July 2017 Jul 27, 2017
@sandy081 sandy081 modified the milestones: September 2017, August 2017 Aug 30, 2017
@sandy081 sandy081 modified the milestones: September 2017, October 2017 Sep 25, 2017
@sandy081 sandy081 modified the milestones: October 2017, November 2017 Nov 1, 2017
@sandy081 sandy081 modified the milestones: November 2017, December 2017 Dec 6, 2017
@Yukaii Yukaii mentioned this issue Jan 26, 2018
Closed
4 tasks
@sandy081 sandy081 modified the milestones: January 2018, Backlog Jan 31, 2018
@sandy081 sandy081 modified the milestones: Backlog, February 2018 Feb 14, 2018
@sandy081 sandy081 mentioned this issue Feb 14, 2018
Closed
@sandy081 sandy081 added the tree-widget Tree widget issues label Feb 20, 2018
@sandy081
Copy link
Member

@joaomoreno This is the bug we were debugging today

@sandy081 sandy081 added this to the Backlog milestone May 28, 2018
@sandy081 sandy081 mentioned this issue Jul 13, 2018
Closed
@sandy081
Copy link
Member

@joaomoreno @roblourens May I know what is the update on this? Getting more dups for this bug 😞

@joaomoreno
Copy link
Member

joaomoreno commented Jul 13, 2018 •
edited
Loading

No progress from my side. Since I'm working on that new tree, expansion state will be supported on getChildren, so it will be eventually fixed if you move to it.

For the current fix, I don't mind a quick solution.

@eamodio
Copy link
Contributor

eamodio commented Jul 13, 2018

New tree? Do tell 😄

@sandy081 sandy081 modified the milestones: Backlog, On Deck Jul 13, 2018
@joaomoreno
Copy link
Member

@eamodio Going in stealth mode for now: https://github.com/Microsoft/vscode/tree/master/src/vs/base/browser/ui/tree

@eamodio
Copy link
Contributor

eamodio commented Nov 21, 2018

Any update on this -- as this still causes a poor user experience?

@sandy081
Copy link
Member

New tree is available now from @joaomoreno. Custom view needs adoption of this which I plan next milestone.

@joaomoreno Does this issue gets fixed with new tree?

@sandy081
Copy link
Member

#63566

@roblourens roblourens removed this from the On Deck milestone Feb 5, 2019
@roblourens
Copy link
Member

I think this is N/A now?

@eamodio
Copy link
Contributor

eamodio commented Feb 5, 2019

@roblourens Until #63566 lands (and assuming it fixes the issue) this is still valid.

@sandy081 sandy081 reopened this Feb 5, 2019
@sandy081 sandy081 added this to the February 2019 milestone Feb 5, 2019
@sandy081 sandy081 modified the milestones: February 2019, March 2019 Feb 13, 2019
@joaomoreno joaomoreno modified the milestones: March 2019, Backlog Mar 25, 2019
@eamodio
Copy link
Contributor

eamodio commented Jul 11, 2019

Woo -- It looks like this is fixed now!

@sandy081 sandy081 modified the milestones: Backlog, July 2019 Jul 12, 2019
@alexr00
Copy link
Member

alexr00 commented Jul 12, 2019 •
edited
Loading

Thank you for digging up this issue and bumping it!

@alexr00 alexr00 closed this as completed Jul 12, 2019
@rebornix rebornix added the verified Verification succeeded label Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@sandy081 sandy081

@alexr00 alexr00

Labels
api bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
7 participants
@joaomoreno @roblourens @eamodio @rebornix @weinand @sandy081 @alexr00