Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet Wrap with invalid abbreviation should display error to user #29897

Closed
mjbvz opened this issue Jun 29, 2017 · 4 comments
Closed

Emmet Wrap with invalid abbreviation should display error to user #29897

mjbvz opened this issue Jun 29, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 29, 2017

  • VSCode Version: Code - Insiders 1.14.0-insider (9541932, 2017-06-29T05:07:31.424Z)
  • OS Version: Darwin x64 16.6.0

Steps to Reproduce:

  1. for the html file
text
  1. Put cusor after text and run emmet: wrap with abbreviation
  2. Enter ul li as the abbreviation

expected
message shown about invalid abbreviation.

Actual
Nothing happens

This error is logged in the developer console:

Unable to consume abbreviation node, unexpected 32 at char 3: Error: Unable to consume abbreviation node, unexpected 32 at char 3
    at StreamReader.error (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/node_modules/@emmetio/stream-reader/dist/stream-reader.cjs.js:122:15)
    at consumeElement (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/node_modules/@emmetio/abbreviation/dist/abbreviation.cjs.js:213:16)
    at parse (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/node_modules/@emmetio/abbreviation/dist/abbreviation.cjs.js:289:16)
    at index (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/node_modules/@emmetio/abbreviation/dist/abbreviation.cjs.js:334:15)
    at parse$1 (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/node_modules/@emmetio/expand-abbreviation/dist/expand.cjs.js:44:9)
    at expand$1 (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/node_modules/@emmetio/expand-abbreviation/dist/expand.cjs.js:30:10)
    at Object.expand$$1 [as expand] (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/node_modules/@emmetio/expand-abbreviation/dist/expand.cjs.js:233:5)
    at expandAbbr (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/out/abbreviationActions.js:161:46)
    at expandAbbreviationInRange (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/out/abbreviationActions.js:148:24)
    at vscode.window.showInputBox.then.abbreviation (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/emmet/out/abbreviationActions.js:54:9)
@mjbvz mjbvz added the emmet Emmet related issues label Jun 29, 2017
@vscodebot vscodebot bot added the insiders label Jun 29, 2017
@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 30, 2017
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jun 30, 2017
@isidorn isidorn added the verified Verification succeeded label Jun 30, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 30, 2017

Adding veririfed since I now get the error, however this error could be more user friendly

screen shot 2017-06-30 at 13 53 02

@ramya-rao-a
Copy link
Contributor

Suggestions?

@isidorn
Copy link
Contributor

isidorn commented Jul 3, 2017

@ramya-rao-a if expand and abbreviation are common terms in Emmet than after second though this could be fine. I am not an experienced emmet user to know good terms for this, just for a emmet noob this seemed a bit too harsh

@ramya-rao-a
Copy link
Contributor

Yup, they are common terms

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants