Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting Enter twice breaks my sources #29843

Closed
jrieken opened this issue Jun 29, 2017 · 1 comment
Closed

Hitting Enter twice breaks my sources #29843

jrieken opened this issue Jun 29, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jun 29, 2017

see recording and sources, I have pressed enter, the cursor sits inbetween the text, second enter breaks everything

jun-29-2017 13-03-13

		this.triggerCharacterListener = this.editor.onDidType(text => {
			const lastChar = text.charAt(text.length - 1);
			const supports: ISuggestSupport[] = []; supportsByTriggerCharacter[lastChar];

			if (this.completionModel) {
				const { incomplete, complete } = this.completionModel.resolveIncompleteInfo();
			}

			if (supports) {
				// keep existing items that where not computed by the
				// supports/providers that want to trigger now
				const items: ISuggestionItem[] = [];
				if (this.completionModel) {
					for (const item of this.completionModel.items) {
						if (supports.indexOf(item.support) < 0) {
							items.push(item);
						}
					}
				}
				this.trigger(true, Boolean(this.completionModel), supports, items);
			}
		});
@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jun 29, 2017
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jun 29, 2017
@joaomoreno
Copy link
Member

I just hit this too. 🙈

@rebornix rebornix added this to the June 2017 milestone Jun 29, 2017
@michelkaporin michelkaporin added the verified Verification succeeded label Jun 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants