Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format on paste should only do something when it pastes a new line #29803

Closed
Tyriar opened this issue Jun 28, 2017 · 1 comment
Closed

Format on paste should only do something when it pastes a new line #29803

Tyriar opened this issue Jun 28, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-autoindent Editor auto indentation issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2017

I had the following:

			const linkHandler = new TestTerminalLinkHandler(new TestXterm(), Platform.Windows, null, null,
				new TestContextService(new TestWorkspace('C:\\base')));

I added a new param to the constructor so I pasted in , null to the end, and it went and tried to guess the indentation. It should only ever do this when it inserts new lines imo.

			const linkHandler = new TestTerminalLinkHandler(new TestXterm(), Platform.Windows, null, null,
			new TestContextService(new TestWorkspace('C:\\base')), null);
@rebornix
Copy link
Member

Yes we should not adjust the indentation if we paste content into the middle of a line. Nice catch!

@rebornix rebornix added editor-autoindent Editor auto indentation issues bug Issue identified by VS Code Team member as probable bug labels Jun 28, 2017
@rebornix rebornix added this to the June 2017 milestone Jun 29, 2017
@Tyriar Tyriar added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-autoindent Editor auto indentation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants