Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarkedString cannot link to virtual documents anymore #29751

Closed
jrieken opened this issue Jun 28, 2017 · 4 comments
Closed

MarkedString cannot link to virtual documents anymore #29751

jrieken opened this issue Jun 28, 2017 · 4 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2017

Comments

@jrieken
Copy link
Member

jrieken commented Jun 28, 2017

Since we now only allow for certain schemes in links that come from markdown we have broken links to virtual documents. I don't think that is necessary or a security risk: !href.match(/^http:|https:|file:|mailto:|command:/i). This is related to #29076.
@vscodebot vscodebot bot added the api label Jun 28, 2017
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed api labels Jun 28, 2017
@jrieken
Copy link
Member Author

jrieken commented Jun 28, 2017

This is a regression from previous releases, fyi @kieferrm @egamma

@kieferrm
Copy link
Member

@jrieken good catch.

@kieferrm kieferrm added this to the June 2017 milestone Jun 28, 2017
@jrieken
Copy link
Member Author

jrieken commented Jun 28, 2017

The tricky bit is how to fix this issue. The list of registered schemes is open ended and we don't expose it anywhere...

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 28, 2017

I think we should switch back to using a blacklist of bad schemas, such as javascript:, for now

@mjbvz mjbvz closed this as completed in f2a5365 Jun 28, 2017
@jrieken jrieken added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@jrieken @kieferrm @mjbvz