Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add root folder" on windows adds "file:///c%3a/Users/..." #29691

Closed
roblourens opened this issue Jun 28, 2017 · 3 comments
Closed

"Add root folder" on windows adds "file:///c%3a/Users/..." #29691

roblourens opened this issue Jun 28, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@roblourens
Copy link
Member

Escaped somewhere, seems wrong. If I write an unescaped path manually, it's not accepted.

@roblourens roblourens added the workbench-multiroot Multi-root (multiple folders) issues label Jun 28, 2017
@bpasero bpasero modified the milestones: June 2017, On Deck Jun 28, 2017
@bpasero
Copy link
Member

bpasero commented Jun 28, 2017

@jrieken I see that if I use URI.toString(true) to skip encoding, the file URI looks better, but then I wonder if URI.parse() can correctly handle these URIs?

My usecase is that I want to store root folder URIs in our settings file and currently they show up like this on Windows:

image

@bpasero bpasero closed this as completed Jun 28, 2017
@bpasero bpasero reopened this Jun 28, 2017
@jrieken
Copy link
Member

jrieken commented Jun 28, 2017

I see that if I use URI.toString(true) to skip encoding, the file URI looks better, but then I wonder if URI.parse() can correctly handle these URIs?

Try it ;-) You should be able to use the minimal-escapted variant which only encodes & and # which are both vital.

@bpasero bpasero modified the milestones: June 2017, On Deck Jun 28, 2017
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2017
@bpasero
Copy link
Member

bpasero commented Jun 28, 2017

Verify: on windows root folders in settings show up un-encoded and multi root still works as before.

@roblourens roblourens added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants