Settings: folderValue versus workspaceValue

[dbaeumer]

Tests #29466

• write extension that reads configuration with the getConfiguration2 API.
• have the setting be overridden on the workspace level

Observe: when using inspect the folderValue is not set. For the new API I would have expected that workspaceValue is undefined and folderValue is set.

[sandy081]

@dbaeumer Can you please give an example of the setting and where it is defined?

[dbaeumer]

It is defined the the .vscode/settings.json file

[sandy081]

And there is just one root folder in the workspace?

Edit: Ignore it. It does not matter

[dbaeumer]

Yes, one root folder.

I tested editor.lineNumbers as well and with only one folder I am not able to get the folderValue populated.

[sandy081]

Looks 🐛 to me

[dbaeumer]

• One workspace folder
• editors.lineNumbers=off
  

[dbaeumer]

Some comments after getting a a very good quick introducing on this from @sandy081

• what confuses me is that in the past setting scopes mapped to file location. With the new story this is not true anymore. It depends on the type of the setting. For example editors.lineNumbers is always considered to be a folder setting
• things get even more complicated when a single folder morphs into a workspace
• May be we should always store workspace settings separate and have a workspace folder/file concept which we can open.

[dbaeumer]

With two folders I have no value at all although I defined that value in both settings files in both folders.

[dbaeumer]

Latest build, single folder open and looking at editor.linenumbers.

Shouldn't this now contain a folderValue. I am calling

	let config = vscode.workspace.getConfiguration2('editor');
	let inspect = config.inspect('lineNumbers');
	console.log(inspect);

[sandy081]

folderValue is contained only when a resource is passed otherwise it is just workspaceValue even though (currently) workspace value comes first root folder (which is an implementation detail and will change).