Remove entries from quick open history (and opened editors?) when root folder is removed

[sandy081]

Testing #29510

• Open VS Code with multiple roots A and B
• Use Quick open to open files from B
• Remove the root folder B
• Quick open still shows files from B in recent
• Behaviour does not change even after Reload

[bpasero]

I would argue this works as designed, we never remove entries from the recent history in quick open unless a file gets deleted and we can detect that.

The same is true for files which are opened which do not belong to the workspace, we keep them around.

The quick open history is a history of recently opened files, independent from the origin. I think it should stay agnostic to multi-root. The only impact multi-root should have is to honour files.exclude setting per folder if any.

[sandy081]

Not sure if I like this behaviour of treating explicit and implicit actions same.

I think opening a file that does not belong to workspace and opening a file that belongs to workspace are different. Because, in first case user explicitly open the file using a different user action (Open File / Drag n Drop.. ). In later case, its more implicit. When user removes the root folder from the workspace, the implicit behaviour should not be treated explicit all of a sudden. I think, removing a root folder is like removing all details belonging to that folder.

[bpasero]

Yeah, let's keep it open and see what others have to say. This may or may not be expected behaviour.

@sandy081 there are other parts that might need to react too, would you expect editors to close from a root folder that is removed?

[sandy081]

Yeah, Makes sense to me as I am asking to remove the root folder.

Retaining the editors might leads to expectation to retaining the settings.

[nicksnyder]

I find the current behavior strange, especially in the context of multi folder workspaces. If I remove a folder from my workspace, I expect those files to disappear from quickopen immediately.

I would also be happy if open files from that repo automatically closed. There has been at least one instance where I was scratching my head trying to figure out what I wasn't getting code intelligence on a file and I eventually figured out it was because I had closed the workspace folder.

[EmpireJones]

Similar behavior when deleting a single file:

• the file still shows up in quick open as "recently opened"
• selecting the entry results in a "Unable to open '': File not found" popup, followed by it being removed.

[vscodebot]

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!