GitHub extension: refresh on settings change

[bpasero]

Testing: #29507

When changing the settings (username) I suggest to refresh the view of issues automatically.

[chrmarti]

I have a listener registered and that seems to work. The only case I can reproduce this is when the user setting goes from a non-null value to null. In that case no event is fired. Could this be related to changes you recently made @sandy081 ?

[sandy081]

Will check

[chrmarti]

There have been other fixes that might have improved the experience. Reassigning to you @sandy081 for the remaining one.

[sandy081]

@chrmarti I see the event when the user setting goes from a non-null value to null. Please see the attached video. In the extension, I am listening to configuration change and logging the values of github section and it works as expected

Here is my code in extension

export function activate(context: vscode.ExtensionContext) {
	vscode.workspace.onDidChangeConfiguration(() => {
		console.log(vscode.workspace.getConfiguration('github'));
	});
}

Are there any other steps to reproduce this?

[chrmarti]

Ack, it now works. Guess it must have been fixed. Thanks!