Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide css emmet abbr suggestions when inside style attribute in html files #29066

Closed
ramya-rao-a opened this issue Jun 20, 2017 · 4 comments
Closed
Assignees
Labels
emmet Emmet related issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 20, 2017

<div style="d|"></div>

In the above case, there are no suggestions from the emmet completion provider.
Css abbreviations should be suggested.

@ramya-rao-a ramya-rao-a added emmet Emmet related issues feature-request Request for new features or functionality labels Jun 20, 2017
@ramya-rao-a ramya-rao-a self-assigned this Jun 20, 2017
@ramya-rao-a ramya-rao-a added the help wanted Issues identified as good community contribution opportunities label Jun 20, 2017
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 22, 2017
@ramya-rao-a
Copy link
Contributor Author

Closing this as #29113 can cover this feature ask

@ramya-rao-a
Copy link
Contributor Author

In the latest Insiders it is possible to get css emmet completions inside the style attribute but only if there is a space after the "
<div style=" dn| "> would give the right completion i.e display: none
but <div style="dn|"> wouldn't give any completion

This is because we assume that current word is the abbreviation in case of css. With emmetio/extract-abbreviation@ee01c36 we can use the extract-abbreviation module to fetch the abbreviation correctly

@ramya-rao-a
Copy link
Contributor Author

Emmet completions are now included but only when either manually triggered or when the abbreviation contains non word characters. Currently blocked on #13735

@ramya-rao-a ramya-rao-a modified the milestones: February 2018, March 2018 Feb 27, 2018
@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Mar 11, 2018

Turns out the problem is that completions don't get triggered inside strings. Adding the below will give emmet completions inside the style attribute as expected:

"editor.quickSuggestions": {
        "other": true,
        "comments": false,
        "strings": true
    }

cc @gushuro

@ramya-rao-a ramya-rao-a modified the milestones: March 2018, February 2018 Mar 11, 2018
@ramya-rao-a ramya-rao-a changed the title Provide css emmet abbr suggestions when inside style attribute Provide css emmet abbr suggestions when inside style attribute in html files Mar 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants