Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Github extension #28631

Closed
chrmarti opened this issue Jun 13, 2017 · 9 comments
Closed

Polish Github extension #28631

chrmarti opened this issue Jun 13, 2017 · 9 comments
Assignees
Labels
plan-item VS Code - planned item for upcoming
Milestone

Comments

@chrmarti
Copy link
Collaborator

No description provided.

@chrmarti chrmarti added the plan-item VS Code - planned item for upcoming label Jun 13, 2017
@chrmarti chrmarti added this to the June 2017 milestone Jun 13, 2017
@chrmarti chrmarti self-assigned this Jun 13, 2017
@eamodio
Copy link
Contributor

eamodio commented Jun 13, 2017

@chrmarti What is the GitHub extension?

@chrmarti
Copy link
Collaborator Author

It's a not yet published example for custom views.

@chrmarti
Copy link
Collaborator Author

I should add: We will polish that to make useful beyond being an example.

@eamodio
Copy link
Contributor

eamodio commented Jun 13, 2017

Is it in a public repo at this point? Would love to take a look at it as I'm working on custom views for GitLens :)

@chrmarti
Copy link
Collaborator Author

It's here: https://github.com/chrmarti/vscode-githubissues. I'll move it to Microsoft's account before we publish the extension.

Let us know what you have in mind for GitLens. @rebornix is working on another extension adding a few Git-specific views.

@eamodio
Copy link
Contributor

eamodio commented Jun 13, 2017

I'm still experimenting at this point, but thinking about a few different options (maybe 2 views).

Here is a peek at one idea
image

Where click on one of the "file" nodes would open a diff with the changes between that file and the previous version.

@rebornix
Copy link
Member

@eamodio I'm really happy to see we share the same thoughts, you can take a look at #28657 and see where I have gone. I'm going to open source the repo and publish the ext in one day or two.

Do you think it's a good idea to join forces as the list/diff part is the same :)

@eamodio
Copy link
Contributor

eamodio commented Jun 13, 2017

Doh -- so I have 1 or 2 days to get this out first? ;) j/k

I would definitely be interested in joining forces (not sure what that looks like at this point though) -- As your PR list was something I wanted to tackle as well.

I have a slack for GitLens https://join.slack.com/vscode-gitlens/shared_invite/MTk0NjA3OTIwNTE3LTE0OTY4OTc3NzQtMWQxODFhZWMyMA (link is good for ~24days) and would love to talk more about it.

@chrmarti
Copy link
Collaborator Author

Just published the GitHub Issues and PRs extension: https://marketplace.visualstudio.com/items?itemName=ms-vscode.github-issues-prs

New repo: https://github.com/Microsoft/vscode-github-issues-prs

@chrmarti chrmarti mentioned this issue Jun 27, 2017
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

3 participants