Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish VS Code sourcemaps #2863

Closed
ianwesterfield opened this issue Feb 9, 2016 · 4 comments
Closed

Publish VS Code sourcemaps #2863

ianwesterfield opened this issue Feb 9, 2016 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@ianwesterfield
Copy link

I was going to look into a possible bug in VS Code, but toggling Developer Tools reveals minified scripts with no apparent source mapping.

I see the use of gulp-sourcemaps in the build scripts, but I've never used it so I'm unsure how to verify it is actually doing it's job or why Chrome isn't parsing them if it is. I'll look deeper into it later on unless I get word back I'm doing something wrong 😄

@ianwesterfield ianwesterfield changed the title Prettify VS Code? Source Maps in VS Code? Feb 9, 2016
@ianwesterfield ianwesterfield changed the title Source Maps in VS Code? Source maps in VS Code missing? Feb 9, 2016
@ianwesterfield
Copy link
Author

Cloned the main branch and built - seeing the source, but not the same files as in the release.

I might be reading the code wrong, but it seems...

gulp.task('minify-vscode', ['clean-minified-vscode', 'optimize-vscode'], common.minifyTask('out-vscode', false));

... is telling gulp-sourcemap to not include the the source map comment for workbench.main, however missing this sounds like Chrome won't know where to get the source from, which would normally I guess be in this missing comment. Is this accurate?

@joaomoreno
Copy link
Member

@ianwesterfield Cool. We've been wanting to put the sourcemaps online for a while now. Let me work on that.

@joaomoreno joaomoreno added this to the Feb 2016 milestone Feb 11, 2016
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Feb 11, 2016
@joaomoreno joaomoreno changed the title Source maps in VS Code missing? Publish VS Code sourcemaps Feb 11, 2016
@joaomoreno joaomoreno assigned alexdima and unassigned joaomoreno Feb 16, 2016
@alexdima
Copy link
Member

@joaomoreno Maybe no more need to ship the plugin host sourcemap then?

@joaomoreno joaomoreno reopened this Feb 16, 2016
@joaomoreno
Copy link
Member

👍

@alexdima alexdima added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants