Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke TaskGroup #27575

Closed
jrieken opened this issue May 30, 2017 · 6 comments
Closed

Nuke TaskGroup #27575

jrieken opened this issue May 30, 2017 · 6 comments
Assignees
Labels
tasks Task system issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented May 30, 2017

In vscode.d.ts there is TaskGroup without any usage it should be removed

@jrieken jrieken added this to the May 2017 milestone May 30, 2017
@dbaeumer
Copy link
Member

It has usage, but not inside vscode.d.ts. These groups have special meaning in the core. If you for example assign build you can trigger the task using Ctrl+Shift+B. Same for test. I defined the other since there are pushes to add a Build menu to VS Code with Build, Rebuild All, Clean, ...

I made this a string so that users can extend these groups. I defined constants so that extensions writers don't mistype them. However since this is now open and we need to differentiate our group from other groups I propose that we start ours with $ and throw is someone assigns an unknown group.

Any objection?

@jrieken
Copy link
Member Author

jrieken commented May 31, 2017

I made this a string so that users can extend these groups.

How? I assign a different string to the group-property but how will it manifest in the UI? Will I get a new command to run all foo-group tasks? Is this then a human readable label?

@dbaeumer
Copy link
Member

Yes, don't get choked but there are discussion to have an explorer tree extension to render task in various outlines. One would be by group, name, hierarchy, ...

One 'group' people were asking for is linting since it is not always the same as building.

@dbaeumer
Copy link
Member

Agree that a human readable label needs some contribution then as well.

@dbaeumer dbaeumer modified the milestones: June 2017, May 2017 May 31, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Jun 6, 2017

I think a task group with a human readable label would best be contributed via a extension points like menu items or tool bar buttons.

@dbaeumer dbaeumer added tasks Task system issues under-discussion Issue is under discussion for relevance, priority, approach labels Jun 6, 2017
@dbaeumer
Copy link
Member

Fixed in latest API version

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tasks Task system issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants