Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.10.7-insider] Salsa does not honor JSDoc for object methods #2630

Closed
astral-sa opened this issue Feb 2, 2016 · 2 comments
Closed

[0.10.7-insider] Salsa does not honor JSDoc for object methods #2630

astral-sa opened this issue Feb 2, 2016 · 2 comments
Assignees

Comments

@astral-sa
Copy link

Testing Salsa on 0.10.7-insider (6c2d51a)
[email protected]
typescript.tsdk properly configured

Similar to #2440 (microsoft/TypeScript#6552) for #2218:

var someObject = {
    /**
     * @param {string} param1 Some string param.
     * @param {number} parm2  Some number param.
     */
    someMethod: function(param1, param2) {
        console.log(param1);
        return false;
    }
};

salsa_method

@egamma
Copy link
Member

egamma commented Feb 2, 2016

This issue was moved to microsoft/TypeScript#6825

@egamma
Copy link
Member

egamma commented Feb 2, 2016

Verified that the above JSDoc comment works properly for an ordinary function.

Moving to TS

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants