Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//@ts-check can not support vue file #26165

Closed
Moerj opened this issue May 7, 2017 · 5 comments
Closed

//@ts-check can not support vue file #26165

Moerj opened this issue May 7, 2017 · 5 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster javascript JavaScript support issues

Comments

@Moerj
Copy link

Moerj commented May 7, 2017

  • VSCode Version:1.12.1
  • OS Version:macOS sierra

Steps to Reproduce:

When I use //@ts-check for *.vue files. It not supports.
Variable can not be recognized correctly.

Like this:

qq20170508-020234 2x

How can I use ts-check on vue?

@egamma egamma added the javascript JavaScript support issues label May 7, 2017
@mjbvz mjbvz added *caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster and removed *caused-by-extension Issue identified to be caused by an extension labels May 8, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 8, 2017

What vue extension are you using? In current insiders builds this should now work if you just set vue files to use the html language mode, but a vue extension may have to be updated to support this

@Moerj
Copy link
Author

Moerj commented May 9, 2017 via email

@octref
Copy link
Contributor

octref commented May 9, 2017

@mjbvz This wouldn't be resolved until contextual typing is added to vue.d.ts.

active is in the object returned by this.data. With vue's current type declaration the return result won't be used to contextually type this.

More details here: vuejs/vetur#94 (comment)

@octref
Copy link
Contributor

octref commented May 9, 2017

@mjbvz So I think it's ok to close this as it's really a vue / TS issue. // @check-ts works fine in vetur.

@mjbvz mjbvz added the *caused-by-extension Issue identified to be caused by an extension label May 10, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 10, 2017

Thanks @octref! Closing as caused by extension. Please follow up on the Vetur repo

@mjbvz mjbvz closed this as completed May 10, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster javascript JavaScript support issues
Projects
None yet
Development

No branches or pull requests

4 participants