Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into removing file stat checks in terminal link detection #25024

Closed
Tyriar opened this issue Apr 19, 2017 · 2 comments
Closed

Look into removing file stat checks in terminal link detection #25024

Tyriar opened this issue Apr 19, 2017 · 2 comments
Assignees
@Tyriar
Labels
debt Code quality issues *out-of-scope Posted issue is not in scope of VS Code perf terminal Integrated terminal issues
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 19, 2017

Performance concerns brought up in #24451 (comment)

Notes:

  • Link validation was added in 1.11
  • Folders (eg. the prompt cwd) will be underlines but do nothing when clicked
  • File regexes may need to be improved?
  • Verify that web links still override local links
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues perf labels Apr 19, 2017
@Tyriar Tyriar added this to the May 2017 milestone Apr 19, 2017
@Tyriar Tyriar self-assigned this Apr 19, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Apr 19, 2017

/cc @bpasero

This was referenced Apr 19, 2017
Merged
Closed
@Tyriar Tyriar modified the milestones: Backlog, May 2017 May 25, 2017
@Tyriar Tyriar mentioned this issue Jan 22, 2018
Closed
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Sep 12, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 12, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues *out-of-scope Posted issue is not in scope of VS Code perf terminal Integrated terminal issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@Tyriar