Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa: "Implicit globals" leak into member completions but not global completions? #2447

Closed
alexdima opened this issue Jan 27, 2016 · 1 comment
Assignees

Comments

@alexdima
Copy link
Member

Testing #2218

IMHO member completions should get less suggestions than the global completions, not the other way around:

function f() {
    // helloWorld leaks from here into the global space?
    if (helloWorld) {
        return 3;
    }
    return 5;
}

// helloWorld is proposed here
// Number(3).

// helloWorld is not proposed here
// hello

salsa-member-completion

@egamma
Copy link
Member

egamma commented Jan 27, 2016

This issue was moved to microsoft/TypeScript#6654

@egamma egamma closed this as completed Jan 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants