Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa type inference should find or types #2431

Closed
alexdima opened this issue Jan 27, 2016 · 1 comment
Closed

Salsa type inference should find or types #2431

alexdima opened this issue Jan 27, 2016 · 1 comment
Assignees

Comments

@alexdima
Copy link
Member

Testing #2218

function a1() {
    return 5;
}

function a2() {
    if (1) {
        return 5;
    } else {
        return '5';
    }
}

Hovering over a1() shows its return type is number. Hovering over a2() shows its return type is any. IMHO it should show number|string -- maybe this inference code was written before or types were introduced?

@egamma
Copy link
Member

egamma commented Jan 27, 2016

This issue was moved to microsoft/TypeScript#6663

@egamma egamma closed this as completed Jan 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants