Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable set Ctrl+/ for Toggle Line Comment #24218

Closed
diogoca opened this issue Apr 7, 2017 · 9 comments
Closed

Unable set Ctrl+/ for Toggle Line Comment #24218

diogoca opened this issue Apr 7, 2017 · 9 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux
Milestone

Comments

@diogoca
Copy link

diogoca commented Apr 7, 2017

  • VSCode Version: Code 1.11.1 (d9484d1, 2017-04-06T13:55:56.395Z)
  • OS Version: Linux x64 4.4.0-70-generic
  • Extensions:
Extension Author Version
php-debug felixfbecker 1.10.0
php-intellisense felixfbecker 1.1.4

Steps to Reproduce:

  1. Go to Keyboard Shortcuts
  2. Search "Toggle Line Comment"
  3. Try to set CTRL + /

Keybinding will bind: CTRL + unknown

Ps: On previous update was working... My keyboard is Wireless Keyboard 800 with Ç letter

@chrmarti
Copy link
Collaborator

chrmarti commented Apr 7, 2017

Which keyboard layout is this?

@rafaelcneves
Copy link

rafaelcneves commented Apr 7, 2017

The same here, I'm using Ubuntu 16.04 x64 and Code 1.11.1
And if I add this manually throws an error to me.
It seems that vscode doesn't recognize my keyboard, but I can type this character normally.
image

@alexdima alexdima added the linux Issues with VS Code on Linux label Apr 10, 2017
@alexdima
Copy link
Member

@rafaelcneves You might be suffering from a different issue. Please open a separate issue and include your keyboard layout. I can then proceed to analyze what is going on under the respective keyboard layout.

@diogoca

Can you please let us know what your keyboard layout is?

What scan code do we receive from Electron when you press this key combination?

  • open Preferences > Keyboard Shortcuts
  • click on keybindings.json
  • on the right hand side editor click on Define Keybinding
  • press the key combination that has a problem
  • hover with the mouse over the input box

image

@alexdima alexdima added info-needed Issue requires more information from poster keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues labels Apr 10, 2017
@alexdima alexdima added this to the Backlog milestone Apr 10, 2017
@diogoca
Copy link
Author

diogoca commented Apr 10, 2017

@alexandrudima yeah

Keyboard layout: Portuguese (Brazilian)

System Locale: LANG=pt_BR.UTF-8
LANGUAGE=pt_BR:pt
VC Keymap: n/a
X11 Layout: br
X11 Model: pc105

Scan code from Electron (pressed CTRL + /)

image

@alexdima
Copy link
Member

alexdima commented Apr 10, 2017

@diogoca Thank you for following through. I cannot reproduce on Ubuntu 16.04 using the same keyboard layout.

I get code: Slash, keyCode: 191, key: / and not code: IntlRo, keyCode: 191, key: Unidentified. What linux distribution are you using? Are you using Linux installed on real hardware and connected with a keyboard or are you using some sort of remoting software?

I'm thinking this might be similar to #24107

@alexdima
Copy link
Member

Duplicate of #24147 -- IntlRo should not map to KeyCode.Unknown.

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 10, 2017
@diogoca
Copy link
Author

diogoca commented Apr 10, 2017

Hi,

sb_release -a
No LSB modules are available.
Distributor ID: LinuxMint
Description: Linux Mint 18.1 Serena
Release: 18.1
Codename: serena

Real hardware with wireless keyboard. I think that Linux is using native remote software, once that I did not install any other software.

@rafaelcneves
Copy link

rafaelcneves commented Apr 10, 2017

@alexandrudima I'm sorry, but It's unlikely to be a different issue.. I have the same keyboard layout of @diogoca, and if I try to do the same of him I got the same issue..
screenshot from 2017-04-10 14-38-24

@diogoca
Copy link
Author

diogoca commented Apr 11, 2017

#24147 (comment) fixed that...

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux
Projects
None yet
Development

No branches or pull requests

4 participants