Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title bar too big in some screens, does not scale with zoom #236272

Open
juanep97 opened this issue Dec 16, 2024 · 3 comments
Open

Title bar too big in some screens, does not scale with zoom #236272

juanep97 opened this issue Dec 16, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@juanep97
Copy link

juanep97 commented Dec 16, 2024

In Ubuntu 24.04 under Wayland, in my main hidpi monitor, the title bar size is correct. When I connect a second (bigger) monitor, and other applications are moved over to the second screen, they are correctly automatically resized down (their size in pixel decreased, so their physical size stays more or less constant). VSCode is not resized, and therefore appears too big. I can zoom out inside VSCode so the size is corrected, but this does not affect the title bar, which, as can be seen in the image, stays way too big compared to other windows (next to a terminal in the example).

There could be two ways of fixing this behavior: allow zooming out the title bar, and/or make vscode correctly resize when moving to a monitor of different size. Ideally both.

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.96.0
  • OS Version: Ubuntu 24.04 LTS

Steps to Reproduce:

  1. Using vscode in Ubuntu (Wayland)
  2. Use custom title bar

Image

@juanep97 juanep97 changed the title Title bar too big in secondary monitor, does not scale with zoom Title bar too big in some screens, does not scale with zoom Dec 16, 2024
@juanep97
Copy link
Author

juanep97 commented Dec 16, 2024

I found out vscode is correctly scaled between monitors at different scalings when Wayland is enabled (code --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform-hint=auto). Maybe this could be the default.

@benibenj benibenj added bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues labels Dec 17, 2024
@benibenj
Copy link
Contributor

@deepak1556 do you have context on this?

@deepak1556
Copy link
Collaborator

deepak1556 commented Dec 17, 2024

Seems like an issue specific to xwayland, definitely a runtime issue. We would need to create a minimal repro with WCO and file an issue at https://github.com/electron/electron/issues

For using native wayland as default, please follow #207033 which will offer some sort of persistent setting in the application.

@benibenj benibenj added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Dec 17, 2024
@benibenj benibenj added this to the Backlog milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants