Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal does not linkify unqualified file paths #23574

Closed
sqlProvider opened this issue Mar 29, 2017 · 10 comments
Closed

Terminal does not linkify unqualified file paths #23574

sqlProvider opened this issue Mar 29, 2017 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Milestone

Comments

@sqlProvider
Copy link

  • VSCode Version: 1.10.2 (1.10.2)
  • OS Version: MacOS 10.12.3 (16D32)

image

vscode can't read src/ folder in my opinion.

@chrmarti
Copy link
Collaborator

tsc is the TypeScript compiler. That is independent of VSCode. Do you have a tsconfig.json for the project?

@sqlProvider
Copy link
Author

yes I have @chrmarti

@chrmarti
Copy link
Collaborator

The screenshot is incomplete, my guess is that you should use relative paths in your 'import' or 'require()' statements. Please contact the TypeScript project for further help, as this is not an issue with VSCode from all I see.

@chrmarti chrmarti added the invalid Issue identified as not relevant or not valid label Mar 29, 2017
@sqlProvider
Copy link
Author

VSCode will be open this files for currently release but not open its.

@chrmarti
Copy link
Collaborator

Sorry, I don't understand. If the output of tsc shows the problem, you need to work on your project configuration. That is not part of VSCode and I would suggest you contact https://github.com/Microsoft/TypeScript.

@sqlProvider
Copy link
Author

I'm talking about that. https://code.visualstudio.com/updates/v1_10#_links-in-the-terminal
When I click file path, VSCode do nothing.

@chrmarti
Copy link
Collaborator

Got it :)

@chrmarti chrmarti reopened this Mar 30, 2017
@chrmarti chrmarti added terminal Integrated terminal issues and removed invalid Issue identified as not relevant or not valid labels Mar 30, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2017

Ah, this happens because we need a qualified path that starts with ./, ../, ~/, etc. In 1.11 these links will be validated so they will no longer show hover feedback if they don't navigate anywhere.

This is a valid request though, to have links when the path is not qualified. I don't think there's an issue tracking this yet.

It's blocked on knowledge of the current cwd #20676

@Tyriar Tyriar added the feature-request Request for new features or functionality label Mar 30, 2017
@Tyriar Tyriar added this to the Backlog milestone Mar 30, 2017
@Tyriar Tyriar changed the title VSCode can't open files Terminal does not linkify unqualified file paths Mar 30, 2017
@sqlProvider
Copy link
Author

@Tyriar

Vscode does not show any errors without opening the file. We are trying to see mistakes on tsc. And it can be a bit difficult to read the order and go to the specified file. It would be really nice for us to add qualified file paths.

@Tyriar
Copy link
Member

Tyriar commented Dec 22, 2017

This has been fixed for a while

@Tyriar Tyriar closed this as completed Dec 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants