Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding autoguess - weird case #23508

Closed
roblourens opened this issue Mar 28, 2017 · 1 comment
Closed

Encoding autoguess - weird case #23508

roblourens opened this issue Mar 28, 2017 · 1 comment
Assignees
@bpasero
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
March 2017

Comments

@roblourens
Copy link
Member

Testing #23322

  • Enable autoGuessEncoding
  • Open QuietLight.tmTheme in the vscode repo
  • It's guessed to be EUC-JP, apparently because of a ü character on line 6. Other than that, it includes only ASCII characters

I can't make the same thing happen in another file by inserting ü characters so I don't know whether it's a jschardet bug or whether our confidence threshold is too low.
@bpasero bpasero added this to the March 2017 milestone Mar 29, 2017
@bpasero
Copy link
Member

bpasero commented Mar 29, 2017

aadsm/jschardet#29

@bpasero bpasero closed this as completed Mar 29, 2017
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
2 participants
@roblourens @bpasero