Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message when exit-ing terminal #23465

Closed
jrieken opened this issue Mar 28, 2017 · 2 comments
Closed

error message when exit-ing terminal #23465

jrieken opened this issue Mar 28, 2017 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues

Comments

@jrieken
Copy link
Member

jrieken commented Mar 28, 2017

  • (mac)
  • open a new terminal
  • type exit
  • 🐛 ugly error message shows centrally in the editor
@Tyriar
Copy link
Member

Tyriar commented Mar 28, 2017

It only does this when the shell exits with a non-zero exit code, if you use exit 0 it will not show this. Right now we can't reliably tell why a shell returned such a code. I guess this is blocked by #20676 and after that we could verify whether it exited using an explicit exit action and special case it? It seems a bit ugly though.

@Tyriar Tyriar added terminal Integrated terminal issues info-needed Issue requires more information from poster labels Mar 28, 2017
@vscodebot vscodebot bot closed this as completed May 24, 2017
@vscodebot
Copy link

vscodebot bot commented May 24, 2017

This issue has been closed automatically because it needs more information and has not had recent activity. Please refer to our guidelines for filing issues. Thank you for your contributions.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants