Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit + undo removes all BPs in file #22492

Closed
roblourens opened this issue Mar 12, 2017 · 7 comments
Closed

Edit + undo removes all BPs in file #22492

roblourens opened this issue Mar 12, 2017 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

  • Start debug session with a few breakpoints
  • Accidentally add or remove a newline
  • Undo
  • All BPs in file are gone

If you delete the newline and save, then this doesn't happen.

@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2017

Can not reproduce.
Do you see this all the time.
Do you aslo see other editor decorations being gone - for instance the lightbulb or some errors in the editor?

bpsdisapear

@isidorn isidorn added this to the March 2017 milestone Mar 14, 2017
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster labels Mar 14, 2017
@roblourens
Copy link
Member Author

I just noticed that this only happens with inspector, but I don't see what the debug adapter could have to do with it.

@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2017

I also can not reproduce with inspector

@roblourens
Copy link
Member Author

I'll debug a little more

@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2017

Assigning to you so you get more data, assign back to me once you have somethign 😊

@roblourens
Copy link
Member Author

Turns out to be a node2 bug triggered by updating a bunch of BPs at once. When doing this, vscode deletes all BPs one by one, then resets them.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 20, 2017
@roblourens
Copy link
Member Author

roblourens commented Mar 31, 2017

Should be easy for someone to verify, if you want to repro it, it should be easier with anything that will slow the process down, like

  • many breakpoints
  • in a larger file
  • when sourcemaps are in play

@chrmarti chrmarti added the verified Verification succeeded label Apr 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants