Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove a BP when it's moved past the end of the file #21673

Closed
roblourens opened this issue Mar 2, 2017 · 1 comment
Closed

Can't remove a BP when it's moved past the end of the file #21673

roblourens opened this issue Mar 2, 2017 · 1 comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality

Comments

@roblourens
Copy link
Member

See microsoft/vscode-node-debug2#90

If the debug adapter returns a BP at line 11, but the file is only 10 lines long, then it can't be removed by clicking on the BP icon. If you click on that line, it tries to set a new BP on 10, but doesn't remove the one at 11

Ideally the debug adapter wouldn't do that, but in this case, Chrome/Node will actually return the BP being on an invalid line. No clue why. And the debug adapter doesn't know how many lines the file is, so it can't validate/trim it.

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Mar 8, 2017
@isidorn isidorn removed their assignment Mar 8, 2017
@isidorn
Copy link
Contributor

isidorn commented Mar 8, 2017

You can still remove it using the breakpoint pane.
I could leave it open as a feature request but I do not think anybody would tackle it so closing for now. If popularity rises I can reopen

@isidorn isidorn closed this as completed Mar 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants