Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can tab through notebook when it's in the background #199469

Closed
roblourens opened this issue Nov 29, 2023 · 4 comments · Fixed by #209059
Closed

Can tab through notebook when it's in the background #199469

roblourens opened this issue Nov 29, 2023 · 4 comments · Fixed by #209059
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-accessibility notebook-globaltoolbar verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

  • Open a notebook
  • Switch to a text editor tab
  • Enable "tab moves focus mode"
  • Tab through the UI. After the status bar, the focus disappears. Check with devtools, see that focus is on notebook toolbars
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-accessibility labels Dec 4, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Mar 29, 2024
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 29, 2024
@rzhao271 rzhao271 modified the milestones: March 2024, April 2024 Mar 29, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2024
@justschen
Copy link
Contributor

justschen commented Apr 24, 2024

@amunger not sure if this is the same issue or just intended, but the tabbing seems super random and does go into the notebook cell:

Screen.Recording.2024-04-24.at.5.03.07.PM.mov

@amunger
Copy link
Contributor

amunger commented Apr 24, 2024

It's separate, and I think that's the expected behavior: It's navigating among different toolbars, and once focused in a toolbar, you can use arrow keys to navigate. It jumps to that particular cell since that's where you were previously focused (I assume)

@meganrogge
Copy link
Contributor

@amunger the focus still gets stuck in the notebook when I'm in tab moves focus mode.

@meganrogge meganrogge reopened this Apr 24, 2024
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Apr 24, 2024
@rebornix rebornix modified the milestones: April 2024, May 2024 Apr 25, 2024
@amunger
Copy link
Contributor

amunger commented Apr 29, 2024

@meganrogge - what do you mean it gets stuck? Do you have repro steps? That sounds different than what this issue was for.

@amunger amunger closed this as completed May 29, 2024
@joyceerhl joyceerhl added the verified Verification succeeded label May 29, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-accessibility notebook-globaltoolbar verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants