Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaunch terminal hides terminal after reloading window #196483

Open
joyceerhl opened this issue Oct 24, 2023 · 2 comments
Open

Relaunch terminal hides terminal after reloading window #196483

joyceerhl opened this issue Oct 24, 2023 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-persistence Relating to process reconnection or process revive

Comments

@joyceerhl
Copy link
Contributor

Testing microsoft/vscode-python#22288

  1. Do steps from venv not activated for cmd on Windows vscode-python#22309
  2. Reload window
  3. See that Python extension wants to relaunch terminal
  4. Click relaunch terminal
  5. 🐛 terminal pane hides itself and doesn't come back
@karrtikr karrtikr changed the title Relaunch terminal hides terminal Relaunch terminal hides terminal after reloading window Oct 24, 2023
@karrtikr karrtikr removed their assignment Oct 24, 2023
@karrtikr karrtikr transferred this issue from microsoft/vscode-python Oct 24, 2023
@karrtikr
Copy link
Contributor

karrtikr commented Oct 24, 2023 •
edited
Loading

I'm able to reproduce this issue, thanks. Seems that if we reload the window before relaunching the terminal, and then try relaunching it after, it hides the terminal.

image

@karrtikr
Copy link
Contributor

Steps to reproduce:

  • Apply environment collection
  • See that extension wants to relaunch terminal
  • Reload window instead
  • Observe the ⚠️ sign still suggests that terminal needs to be relaunched
  • Relaunch terminal now
  • Terminal hides itself 🐛

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-persistence Relating to process reconnection or process revive labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-persistence Relating to process reconnection or process revive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @karrtikr @joyceerhl