Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown Scroll Sync Perf Improvements #19092

Closed
3 tasks done
mjbvz opened this issue Jan 23, 2017 · 1 comment
Closed
3 tasks done

Markdown Scroll Sync Perf Improvements #19092

mjbvz opened this issue Jan 23, 2017 · 1 comment
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities markdown Markdown support issues perf verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 23, 2017 •
edited
Loading

A few perf improvements could be made for the markdown scroll synchronization implementation. I have not noticed any major problems, even with long documents, but slower machines may start being impacted by these

  • Throttle sync events
  • Cache list of line elements and their position on the page
  • Binary search to find the closest elements instead of linear search
@mjbvz mjbvz added markdown Markdown support issues perf labels Jan 23, 2017
@mjbvz mjbvz self-assigned this Jan 23, 2017
@mjbvz mjbvz added the feature-request Request for new features or functionality label Apr 20, 2017
@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Oct 20, 2017
@mjbvz mjbvz added this to the December 2017/January 2018 milestone Dec 18, 2017
@mjbvz
Copy link
Collaborator Author

mjbvz commented Dec 18, 2017

Binary search added by #40401

@mjbvz mjbvz closed this as completed in 55382a1 Dec 18, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Jan 30, 2018
@chrmarti chrmarti added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities markdown Markdown support issues perf verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@chrmarti @mjbvz