Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a command line flag to disable safeStorage #189501

Closed
bpasero opened this issue Aug 2, 2023 · 2 comments
Closed

Provide a command line flag to disable safeStorage #189501

bpasero opened this issue Aug 2, 2023 · 2 comments
Assignees
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 2, 2023

Same as --disable-keytar, something that entirely skips the use of safeStorage for our integration and smoke tests to prevent possibly login dialogs blocking the run.

I am not sure if we would have to adopt it for our extension test runner as well: https://github.com/microsoft/vscode-test/blob/453dba554a09d05116491cf2f82fe1341c537b6e/lib/runTest.ts#L131-L142

@bpasero bpasero added the debt Code quality issues label Aug 2, 2023
@bpasero bpasero added this to the August 2023 milestone Aug 2, 2023
@TylerLeonhardt
Copy link
Member

/duplicate #188432

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 2, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants