Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UNC security setting usability by allowing wildcards #183783

Closed
wpcoc opened this issue May 30, 2023 · 2 comments
Closed

Improve UNC security setting usability by allowing wildcards #183783

wpcoc opened this issue May 30, 2023 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) unc

Comments

@wpcoc
Copy link

wpcoc commented May 30, 2023

1.78.1 recently introduced UNC path filtering (see commit 6a995c4). In doing so, this created a barrier to opening simple text files on local network servers, which is a major frustration. I would prefer an option to just switch this feature off (but I probably don't understand how serious the issue is when UNC paths are misused). In the meantime, I have attempted to use wildcards to capture the servers on the network, which use a naming convention. But the UNC path filters do not allow wildcards, meaning UNC paths on the same network need to be added manually in each case.

I propose allowing wildcards on this setting, such that .example.com would cover \server1.example.com, \server2.example.com, etc. Also, the following would work: server, which would match server1, server2, etc.

This may render the security aspect of this setting less useful - there's often a trade-off between usability and security.

@bpasero
Copy link
Member

bpasero commented May 31, 2023

/duplicate #182055

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label May 31, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) unc
Projects
None yet
Development

No branches or pull requests

5 participants