Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show source name in callstack even when path is provided #18234

Closed
roblourens opened this issue Jan 6, 2017 · 2 comments
Closed

Show source name in callstack even when path is provided #18234

roblourens opened this issue Jan 6, 2017 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Jan 6, 2017

For microsoft/vscode-chrome-debug-core#150

@roblourens roblourens added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 6, 2017
@isidorn
Copy link
Contributor

isidorn commented Jan 9, 2017

This is fine by me, but not sure if it is contradicting with @weinand comment here

We should just come to a consensus, what has priority name or the path?

@weinand
Copy link
Contributor

weinand commented Jan 9, 2017

@isidorn yes, 'name' has priority over 'path' for the callstack 'name' (shown on the right). And 'path' has priority over 'name' for the callstack 'path' (shown on hover).

@isidorn isidorn added this to the January 2017 milestone Jan 9, 2017
@isidorn isidorn closed this as completed in 57f08aa Jan 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants