-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UNC allow list should not fail for resolved mapped network drives or symbolic links #182196
Comments
/fixedWith 35da3a2 |
Steps for verification:
|
For some reason I wish to go back to 1.78 until there is a release which includes the fix. However I cannot find the Windows zip (needed to make VSC portable) on the 1.78 download page. Any idea where to find it? |
The fix for this is in |
@amitasil can you give more details, did you configure the setting accordingly? |
Are we certain this is related to UNC paths? Whats the extension repository, maybe reach out to them as well? |
I am on this issue thread from #182586, that points me to #182274 then to this one. See that someone pointed a cucumber issue here: cucumber/vscode#155 It's a bit confusing honestly. |
I see no UNC mentioned in any of these issues, so I consider it unrelated. |
Seeing an increase in issues (such as #182185) where a mapped network drive or symbolic link points to a UNC path. If you use node.js methods such as
fs.readlink
orfs.realpath.native
to resolve these paths to their UNC equivalent and use them for further file operations, our UNC allow list might prevent use of these paths until you add them to the allow list.We should discuss if there are options here to make this easier on the impacted users. The issue often goes unnoticed because we do not prompt the user on startup for these paths to add them to the allow list.
❗Workaround
Given an exception like this one:
Find the resolved file path (here
//wsl$/Ubuntu-20.04/home...
) and add the hostname of the path (the value between//
and the first/
after that) to thesecurity.allowedUNCHosts
setting (here:wsl$
). Then restart VS Code.See also: https://aka.ms/vscode-windows-unc
The text was updated successfully, but these errors were encountered: