Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First terminal does not follow default. #181515

Closed
tbenthompson opened this issue May 4, 2023 · 5 comments · Fixed by #181832
Closed

First terminal does not follow default. #181515

tbenthompson opened this issue May 4, 2023 · 5 comments · Fixed by #181832
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal-profiles
Milestone

Comments

@tbenthompson
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.78.0
  • OS Version: Mac OS 13.3.1

Steps to Reproduce:

  1. Open a new VSCode window using Codespaces.
  2. The initial terminal window opens a bash terminal. If I kill that terminal and open a new terminal, I get zsh as expected.

I have in my settings.json:

  "terminal.integrated.defaultProfile.linux": "zsh",

I believe this is a duplicate of these closed issues:

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-profiles labels May 4, 2023
@meganrogge meganrogge added this to the Backlog milestone May 4, 2023
@Tyriar
Copy link
Member

Tyriar commented May 8, 2023

I was expecting this would get fixed as part of #175844, cc @jeanp413

@jeanp413
Copy link
Contributor

jeanp413 commented May 8, 2023

@Tyriar It got reopened by Alex, but it only repros using codespaces extension now, before I was able to repro with test resovler extension and remote ssh extension which works as expected now, not sure what's special about codespaces extension as the remote connection logic is the same 🤔

@jeanp413
Copy link
Contributor

jeanp413 commented May 8, 2023

Ah I can repro now, will take a look, it's because codespaces takes > 20s to resolve the remote

Edit:
There's a this._profilesReadyBarrier = new AutoOpenBarrier(20000); 😆

@jeanp413
Copy link
Contributor

jeanp413 commented May 8, 2023

PR #181832

@Tyriar
Copy link
Member

Tyriar commented May 24, 2023

/duplicate #175107

@Tyriar Tyriar closed this as completed May 24, 2023
@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label May 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal-profiles
Projects
None yet
5 participants