Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute Point "timeline/item/context" can't work. #178548

Closed
Particle60 opened this issue Mar 29, 2023 · 9 comments
Closed

Contribute Point "timeline/item/context" can't work. #178548

Particle60 opened this issue Mar 29, 2023 · 9 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster timeline Timeline view issues

Comments

@Particle60
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.76.2
  • OS Version: windows 11

Steps to Reproduce:

  1. add contribute point in package.json
"timeline/item/context": [
    {
        "command": "CofCode.CompareWithPrevious",
        "when": "timelineItem =~ /git:file:commit\\b/
    }
]
  1. argument "e" is undefined. I can't get commit id anymore. It can works in version 1.6x.x, but it seems from 1.70, It can't work anymore.
const compareWithPrevious = (e: { ref: string; previousRef: string; shortRef: string; shortPreviousRef: string }, uri: vscode.Uri, type: string) => {
    ...
};
@ulugbekna
Copy link
Contributor

Hi @Particle60 ,

Thanks for filing the issue.

I reassigned the issue my teammate who could help with the issue. Meanwhile, it would be great if you could confirm whether you can reproduce the problem with VS Code 1.77.0 or not.

@ulugbekna ulugbekna added the info-needed Issue requires more information from poster label Apr 3, 2023
@Particle60
Copy link
Author

@ulugbekna , It still happened in latest v1.77.1.

@Particle60
Copy link
Author

Hi @Particle60 ,

Thanks for filing the issue.

I reassigned the issue my teammate who could help with the issue. Meanwhile, it would be great if you could confirm whether you can reproduce the problem with VS Code 1.77.0 or not.
@ulugbekna , It still happened in latest v1.77.1.

@Particle60
Copy link
Author

refs:#177319

@lszomoru
Copy link
Member

@lramos15, could you please take a look at this? Thank you!

@lszomoru lszomoru assigned lramos15 and unassigned lszomoru Apr 26, 2023
@lszomoru lszomoru added the timeline Timeline view issues label Apr 26, 2023
@lramos15
Copy link
Member

@jrieken Could this be caused by the timeline item API object change?

@jrieken
Copy link
Member

jrieken commented Apr 27, 2023

yes

@lramos15
Copy link
Member

\duplicate #177319

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 27, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster timeline Timeline view issues
Projects
None yet
Development

No branches or pull requests

6 participants