Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Devs: Extending an existing Icon Theme #17700

Closed
warrenbuckley opened this issue Dec 21, 2016 · 3 comments
Closed

Extension Devs: Extending an existing Icon Theme #17700

warrenbuckley opened this issue Dec 21, 2016 · 3 comments
Assignees

Comments

@warrenbuckley
Copy link

  • VSCode Version: 1.8.1
  • OS Version: Windows 10 Pro

I am building a super simple extension that associates a JSON Schema for my file package.manifest from SchemaStore.org and then with the languages contributionPoint are able to ensure that the json language is applied to it & thus the Schema is immediately available.

Continuing this I thought it would be neat to have a custom icon for my file, my initial thought is that I could extend an already icon theme that the user has set/defined in VSCode. So when contributing an Icon set from an extension my assumption if providing a very limited/tiny JSON of associations in my case just for the filenames package.manifest it would display & work against my chosen/active icon theme.

Otherwise I have a tedious task of duplicating or extending this JSON file with say the default VSCode Icon JSON file.

My limited icon JSON file

{
    "iconDefinitions": {
        "_package_manifest_file": {
            "iconPath": "./my-icon.svg"
        }
    },
    "fileNames": {
        "package.manifest": "_package_manifest_file"
    }
}
@warrenbuckley warrenbuckley changed the title Extension: Extending an existing Icon Theme Extension Devs: Extending an existing Icon Theme Dec 21, 2016
@hoovercj
Copy link
Member

Somewhat related: #7669

@warrenbuckley
Copy link
Author

@hoovercj does this mean this will not be supported or considered for future?

@aeschli
Copy link
Contributor

aeschli commented Dec 30, 2016

duplicate of #14662.

We don't know yet if and when we can add such support.

@aeschli aeschli closed this as completed Dec 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants