Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to hide "Open Editors" section when not opening a folder #17473

Closed
tekopabara opened this issue Dec 17, 2016 · 14 comments
Closed

Allow to hide "Open Editors" section when not opening a folder #17473

tekopabara opened this issue Dec 17, 2016 · 14 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@tekopabara
Copy link

tekopabara commented Dec 17, 2016

  • VSCode Version: Code 1.8.0 (3874693, 2016-12-13T17:38:28.425Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions:
Extension Author Version
material-icon-theme PKief 1.1.4
theme-onedark azemoh 0.4.0
vscode-dash deerawan 1.1.2
vscode-great-icons emmanuelbeziat 1.1.28
code-runner formulahendry 0.6.3
vs-color-picker lihui 0.3.2
vscode-flow rtorr 276.3.0
ayu teabyii 0.2.1

Steps to Reproduce:

  1. set "explorer.openEditors.visible": 0 in user settings
  2. the setting does not work as expected
@tekopabara tekopabara changed the title Setting "explorer.openEditors.visible": 0 doesn't hide the open editors area in the exlporer Setting "explorer.openEditors.visible": 0 doesn't hide the open editors area in the explorer Dec 17, 2016
@bpasero
Copy link
Member

bpasero commented Dec 18, 2016

@StyloBill is this when you have a folder opened in VS Code or when using VS Code empty?

@bpasero bpasero added the info-needed Issue requires more information from poster label Dec 18, 2016
@tekopabara
Copy link
Author

Empty VS Code. When a folder is opened, the setting is working as expected.

@bpasero
Copy link
Member

bpasero commented Dec 18, 2016

ok, this is as designed. when no folder is opened you cannot hide the open editors view.

@bpasero bpasero closed this as completed Dec 18, 2016
@bpasero bpasero added the *as-designed Described behavior is as designed label Dec 18, 2016
@Rhywun
Copy link

Rhywun commented Jun 1, 2017

This seems non-intuitive. Why should I need a folder open in order to hide this section that I don't need?

@bpasero
Copy link
Member

bpasero commented Jun 1, 2017

@Rhywun what is the scenario here? what remains in the "Explorer" when you are not opening a folder and you want to hide the "Open Editors" view?

/cc @sandy081 this actually might become more interesting once we have extensions adding views to the explorer so we probably should just allow to hide "open editors" even when not having a folder open.

@bpasero bpasero reopened this Jun 1, 2017
@bpasero bpasero added file-explorer Explorer widget issues feature-request Request for new features or functionality and removed *as-designed Described behavior is as designed info-needed Issue requires more information from poster labels Jun 1, 2017
@bpasero bpasero changed the title Setting "explorer.openEditors.visible": 0 doesn't hide the open editors area in the explorer Allow to hide "Open Editors" section when not opening a folder Jun 1, 2017
@sandy081
Copy link
Member

sandy081 commented Jun 1, 2017

@bpasero Agreed. I would also interested to know the usecase from @Rhywun.

Also is that the user is missing anything if we do not show "Open Editors" (when user is opted to) during no folder scenario?

@sandy081 sandy081 self-assigned this Jun 1, 2017
@bpasero
Copy link
Member

bpasero commented Jun 1, 2017

No I think it is fine to allow this, but that makes the explorer basically just 1 button to open a folder. Now, with extensions support, it is a different story that makes more sense to me if you have an extension view showing up.

@Rhywun
Copy link

Rhywun commented Jun 1, 2017

@bpasero @sandy081 OK, I see what you're getting at. Without a project open, what's the point of having the Explorer open at all. I think I use vscode more often to open single files rather than projects, and after I applied that setting it just seemed weird that the section was still visible.

Maybe a change to consider for the future like you suggest.

@sandy081 sandy081 added this to the June 2017 milestone Jun 7, 2017
@sandy081
Copy link
Member

Related to #27823

@sandy081 sandy081 modified the milestones: Backlog, June 2017 Jun 26, 2017
@bpasero
Copy link
Member

bpasero commented Jul 7, 2017

@sandy081 isn't this done?

@sandy081
Copy link
Member

sandy081 commented Jul 10, 2017

Yes.. now you can hide Open Editors section in any (no) workspace. Re #30120

@sandy081 sandy081 modified the milestones: July 2017, Backlog Jul 10, 2017
@weinand weinand added verification-needed Verification of issue is requested verified Verification succeeded labels Jul 27, 2017
@weinand
Copy link
Contributor

weinand commented Jul 28, 2017

Discussed in standup meeting: this has been already verified.

@t0wer001
Copy link

How do you get the Open Editors section back after removing it from the sidebar?

@sandy081
Copy link
Member

@AntonBramsen You can right click on the viewlet header area to get it back

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants