Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select quickpick not handling mouse click events properly in Insiders #170880

Closed
jkeech opened this issue Jan 9, 2023 · 3 comments · Fixed by #171027
Closed

Multi-select quickpick not handling mouse click events properly in Insiders #170880

jkeech opened this issue Jan 9, 2023 · 3 comments · Fixed by #171027
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@jkeech
Copy link
Member

jkeech commented Jan 9, 2023

When opening as quickpick with multi-select options, the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to #170559 and might have the same cause.

Does this issue occur when all extensions are disabled?: Unsure, probably yes

  • VS Code Version: 1.75.0-insider, Commit: 727d2d3
  • OS Version: Windows11(22621.963), macOS Ventura 13.1; using the VS Code in the web

Steps to Reproduce:

  1. Open a quick pick UI with multiple selection options
  2. 🐛 Try to click a row and observe that the selection doesn't change
  3. Click on the checkbox and observe the selection does change

This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.

@TylerLeonhardt
Copy link
Member

@jkeech can you update to the latest Insiders from today and try again?

@TylerLeonhardt TylerLeonhardt added the info-needed Issue requires more information from poster label Jan 9, 2023
@jkeech
Copy link
Member Author

jkeech commented Jan 9, 2023

@jkeech can you update to the latest Insiders from today and try again?

Sure! It's still broken with the latest insiders:

Version: 1.75.0-insider (Universal)
Commit: 04b15ff
Date: 2023-01-09T05:30:04.983Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin arm64 22.2.0
Sandboxed: Yes

Screen.Recording.2023-01-09.at.10.56.32.AM.mov

Here's Stable for comparison:

Screen.Recording.2023-01-09.at.10.58.57.AM.mov

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues and removed info-needed Issue requires more information from poster labels Jan 11, 2023
@TylerLeonhardt TylerLeonhardt added this to the January 2023 milestone Jan 11, 2023
@TylerLeonhardt TylerLeonhardt added the important Issue identified as high-priority label Jan 11, 2023
@roblourens
Copy link
Member

Yes, more fallout from https://github.com/microsoft/vscode/pull/169680/files, apologies

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 11, 2023
@amunger amunger added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants