Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search.maxResults does not affect how many results are found/highlighted #169017

Open
amunger opened this issue Dec 13, 2022 · 3 comments
Open

search.maxResults does not affect how many results are found/highlighted #169017

amunger opened this issue Dec 13, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member search Search widget and operation issues
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Dec 13, 2022

Steps to Reproduce:

  1. Create a file with the same line 300k times
  2. search for something in the line - 19999+ results are found, and that many are highlighted
  3. change search.maxResults to something above or below the default
  4. search again
    🐛 19999+ results are found, and that many are highlighted
@andreamah andreamah added the bug Issue identified by VS Code Team member as probable bug label Dec 14, 2022
@andreamah andreamah added this to the Backlog milestone Dec 14, 2022
@jhmaster2000
Copy link

+1, extremely annoying and counter-intuitive that the setting only affects the full project-wide search accessible on the sidebar and not the local file Ctrl + F search. I ran into this issue and couldn't even resort to the project-wide search with a strict filter for only the desired file, because it was a standalone file I had open, not within the open project's directory, so it couldn't find it.

Having to resort to grep on the terminal with a different regex engine so regex searches aren't even guaranteed to be 1:1 from VSCode is NOT good user experience.

@andreamah andreamah added search Search widget and operation issues confirmed Issue has been confirmed by VS Code Team member labels Dec 4, 2023
@PrinceOfAbyss
Copy link

Will this stay Open and Confirmed forever? Is this so low on the priority list of the project's devs that's not resolved after 1 year after its confirmation?

@kolya182
Copy link

kolya182 commented Jun 7, 2024

@amunger @bpasero Could you take a look at this issue? And for some reason, I can’t type or paste the value null

337671170-ccee48d4-2234-40ba-bb99-6f7078942b72.mov

Screenshot 2024-06-07 at 3 38 14 PM

@rebornix rebornix assigned osortega and unassigned andreamah Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

6 participants