Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display language change not taking effect for extensions running in remote extension host #166836

Closed
zWingz opened this issue Nov 21, 2022 · 6 comments · Fixed by #174622 or #178857
Closed

Display language change not taking effect for extensions running in remote extension host #166836

zWingz opened this issue Nov 21, 2022 · 6 comments · Fixed by #174622 or #178857
Assignees
@TylerLeonhardt
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone
April 2023

Comments

@zWingz
Copy link
Contributor

zWingz commented Nov 21, 2022 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Codespaces
  • OS Version: Codespaces

Steps to Reproduce:

  1. change display language to zh-cn
  2. see scm view

Some of the characters are Chinese and some are English

image

image
@hediet hediet assigned TylerLeonhardt and unassigned hediet Nov 21, 2022
@TylerLeonhardt
Copy link
Member

/duplicate #165974 (comment)

This will be fixed in the next stable release of vscode projected for this week.

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 6, 2022
@zWingz
Copy link
Contributor Author

zWingz commented Dec 8, 2022 •
edited
Loading

It still not work on Codespace in 1.74.0 @TylerLeonhardt
I think it is because the Chinese (Simplified) (简体中文) Language Pack can't be installed in Web
image

image

image

@TylerLeonhardt TylerLeonhardt reopened this Dec 8, 2022
@TylerLeonhardt
Copy link
Member

Yes this is actually a different issue. Nice catch. The problem here is that you have a client (your browser) and your remote (the Codespaces machine). The Language pack is being used for the client but not the remote and the Git extension runs on the remote side.

Through various brute forcing, this can eventually work... but it's not intuitive at all. Here's an example:

image

You can see that I have the Spanish Language Pack installed on the remote side... I don't remember when I did that or how... but I have it there. If I set to Spanish, it works:
image

However, now I try Chinese:
image

my UI is in Chinese but the language pack is not installed on the Remote side so the Git extension isn't translated:
image

We need to make sure that setting the language in the client gets properly sent to the remote and the language pack installed.

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) and removed *duplicate Issue identified as a duplicate of another issue(s) labels Dec 8, 2022
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Dec 8, 2022
@zWingz
Copy link
Contributor Author

zWingz commented Dec 9, 2022

@TylerLeonhardt you can download the language pack install it from vsix, then restart the codespace.

@TylerLeonhardt TylerLeonhardt modified the milestones: Backlog, January 2023 Dec 9, 2022
@M69W
Copy link

M69W commented Dec 10, 2022

Maybe same issues like #168683 (comment)

@TylerLeonhardt TylerLeonhardt changed the title Builtin extension i18n not work Display language change not taking effect for extensions running in remote extension host Dec 11, 2022
TylerLeonhardt added a commit that referenced this issue Jan 20, 2023
@TylerLeonhardt
Ensure language packs are installed on the server side
95d1dff 
We need the language pack to be on the server side so that extensions running over there are translated correctly.

This ensures the correct language pack is installed before the ExtensionScanner (which will translate the manifest of extensions) kicks in.

Fixes #166836
@TylerLeonhardt TylerLeonhardt mentioned this issue Jan 20, 2023
Closed
@kieferrm kieferrm mentioned this issue Feb 4, 2023
Closed
92 tasks
TylerLeonhardt added a commit that referenced this issue Feb 8, 2023
@TylerLeonhardt
Ensure language packs are installed on the server side
40a88f0 
We need the language pack to be on the server side so that extensions running over there are translated correctly.

This ensures the correct language pack is installed before the ExtensionScanner (which will translate the manifest of extensions) kicks in.

Fixes #166836
TylerLeonhardt added a commit that referenced this issue Feb 16, 2023
@TylerLeonhardt
Ensure language packs are installed on the server side
72e0399 
We need the language pack to be on the server side so that extensions running over there are translated correctly.

This ensures the correct language pack is installed before the ExtensionScanner (which will translate the manifest of extensions) kicks in.

Fixes #166836
@TylerLeonhardt TylerLeonhardt mentioned this issue Feb 16, 2023
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Feb 17, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 17, 2023
@lramos15 lramos15 added the verified Verification succeeded label Feb 22, 2023
@TylerLeonhardt TylerLeonhardt removed the verified Verification succeeded label Feb 22, 2023
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Feb 22, 2023
@TylerLeonhardt
Copy link
Member

So this should work on Desktop now but there's still some work to be done on the web for this.

@lramos15 lramos15 added insiders-released Patch has been released in VS Code Insiders and removed insiders-released Patch has been released in VS Code Insiders labels Feb 22, 2023
@TylerLeonhardt TylerLeonhardt modified the milestones: March 2023, April 2023 Mar 22, 2023
TylerLeonhardt added a commit that referenced this issue Mar 31, 2023
@TylerLeonhardt
Figure out the extension to install on the remote side
4b25c48 
Fixes #166836

When a user using a browser locale other than English loads vscode.dev, they get a localized workbench but the remote needs to know what extension was used to localize it. This ensures the extension id is passed along to the remote.
@TylerLeonhardt TylerLeonhardt mentioned this issue Mar 31, 2023
Merged
TylerLeonhardt added a commit that referenced this issue Apr 1, 2023
@TylerLeonhardt
Figure out the extension to install on the remote side (#178857)
263c692 
Fixes #166836

When a user using a browser locale other than English loads vscode.dev, they get a localized workbench but the remote needs to know what extension was used to localize it. This ensures the extension id is passed along to the remote.
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 1, 2023
@alexr00 alexr00 mentioned this issue Apr 27, 2023
Closed
@alexr00 alexr00 added the verified Verification succeeded label Apr 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Milestone
April 2023
7 participants
@TylerLeonhardt @hediet @lramos15 @zWingz @M69W @alexr00 @vscodenpa