Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sublime: 'Join Lines' command binds to Windows+J on Win 10 #16624

Closed
weinand opened this issue Dec 6, 2016 · 4 comments
Closed

Sublime: 'Join Lines' command binds to Windows+J on Win 10 #16624

weinand opened this issue Dec 6, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Dec 6, 2016

while testing #16545:

On Windows 10 the 'Join Lines' command binds to Windows+J instead of Control+J. This is different from the corresponding binding in Sublime.

@rebornix
Copy link
Member

rebornix commented Dec 6, 2016

AFAIK, we don't have any command binded to Windows key yet, any catch here @alexandrudima ?

@rebornix
Copy link
Member

rebornix commented Dec 6, 2016

Talked with @Tyriar and he mentioned that Windows key is usually taken by system key shortcut, I think that's mainly why we don't do that.

We can ship it this way and see ppl's feedback on this.

@rebornix rebornix added this to the January 2017 milestone Dec 6, 2016
@alexdima
Copy link
Member

alexdima commented Dec 7, 2016

@rebornix Let's ship with the keybinding unbound on Windows and have it bound only on the mac.
I wouldn't want to ship with win+j out of the box and get a plethora of issues on it not working, let's allow our users to find a good keybinding for it (that works for them).

@alexdima alexdima modified the milestones: November 2016, January 2017 Dec 7, 2016
@rebornix
Copy link
Member

rebornix commented Dec 7, 2016

Fixed via 067cf11 .

To verifier, please test that we only have key bindings for Join Lines on Mac. For Windows and Linux, you need to bind them yourselves.

@rebornix rebornix closed this as completed Dec 7, 2016
@rebornix rebornix added verification-needed Verification of issue is requested bug Issue identified by VS Code Team member as probable bug labels Dec 7, 2016
@sandy081 sandy081 added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants