Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing notebook diff with line break change only #164265

Closed
rebornix opened this issue Oct 21, 2022 · 1 comment
Closed

Confusing notebook diff with line break change only #164265

rebornix opened this issue Oct 21, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-diff polish Cleanup and polish issue

Comments

@rebornix
Copy link
Member

Imagine if we have a github issue notebook, which contains multi-line queries with mixed line breaks (a mix of \r\n and \n), and the preferred/detected line break is \n:

  • replace one of the \r\n with \n
  • there is now a change in SCM
  • open the file in notebook diff editor
  • there is no change at all visually

There are two issues here

@rebornix rebornix added polish Cleanup and polish issue notebook-diff bug Issue identified by VS Code Team member as probable bug labels Oct 21, 2022
@rebornix
Copy link
Member Author

The second is also a dup of #19254

@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-diff polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

1 participant