Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt WorkbenchToolbar in notebook title toolbar #161119

Closed
roblourens opened this issue Sep 16, 2022 · 1 comment · Fixed by #185805
Closed

Adopt WorkbenchToolbar in notebook title toolbar #161119

roblourens opened this issue Sep 16, 2022 · 1 comment · Fixed by #185805
Assignees
@rebornix @Yoyokrazy
Labels
debt Code quality issues notebook-globaltoolbar on-testplan
Milestone
June 2023

Comments

@roblourens
Copy link
Member

From #161098 (review)
@rebornix rebornix added the debt Code quality issues label Sep 19, 2022
@rebornix rebornix added this to the September 2022 milestone Sep 19, 2022
@rebornix rebornix modified the milestones: September 2022, October 2022 Sep 29, 2022
@rebornix rebornix modified the milestones: October 2022, November 2022 Oct 21, 2022
@rebornix rebornix modified the milestones: November 2022, December 2022 Nov 23, 2022
@rebornix rebornix modified the milestones: January 2023, February 2023 Jan 23, 2023
@rebornix rebornix modified the milestones: February 2023, March 2023 Feb 17, 2023
@rebornix rebornix modified the milestones: March 2023, April 2023 Mar 21, 2023
@rebornix rebornix modified the milestones: April 2023, May 2023 Apr 24, 2023
@rebornix rebornix modified the milestones: May 2023, June 2023 May 31, 2023
@rebornix
Copy link
Member

We have multiple notebook toolbar rendering strategies, adopting WorkbenchToolbar for all might be challenging but we could explore if we can adopt it for the default setting.

@kieferrm kieferrm mentioned this issue Jun 11, 2023
Closed
74 tasks
This was referenced Jun 12, 2023
Closed
Merged
@Yoyokrazy Yoyokrazy mentioned this issue Jun 22, 2023
Merged
@Yoyokrazy Yoyokrazy mentioned this issue Jun 27, 2023
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@Yoyokrazy Yoyokrazy

Labels
debt Code quality issues notebook-globaltoolbar on-testplan
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

Refactor notebook toolbar (for testing) + dynamic strategy unittesting microsoft/vscode
4 participants
@roblourens @rebornix @Yoyokrazy @vscodenpa